Oc/grating efficiencies #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev_master #215 +/- ##
==============================================
- Coverage 75.21% 75.14% -0.08%
==============================================
Files 147 149 +2
Lines 15248 15336 +88
==============================================
+ Hits 11469 11524 +55
- Misses 3779 3812 +33
☔ View full report in Codecov by Sentry. |
oczoske
requested review from
teutoburg and
hugobuddel
and removed request for
teutoburg
teutoburg
approved these changes
Jun 14, 2023
hugobuddel
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to issue #214 .
It implements a class
SpectralEfficiencythat pulls grating efficiencies from a file and applies them to the FOVs for the corresponding spectral trace. The model is MICADO, for which Ric Davies showed the efficiencies on 2023-06-01.The class loads the efficiencies from a file into a dictionary
self.efficiencieswith the trace_id as the key and aTERCurveas value. The efficiencies are applied to the FieldOfView cubes.The file format for providing the efficiencies is a fits file similar to the trace definition file. It is described in the docstring of the class
SpectralEfficiency.A few very basic unit tests are included. To test with full instrument configurations for METIS and MICADO requires the pull request AstarVienna/irdb#103.